April 2014 – E5K.de

Due to popular demand (read: colleagues asking) I put this little script online which I originally found when googling the web for a way to reduce the count of commits that contain syntax errors in my Puppet recipes.

It will not find all errors (e.g. cyclic or broken requires) but it reduces the risk of overlooking copy&paste errors or typos a lot.

#!/bin/bash
#Script to test puppet files have valid syntax.
#Intended for use with hudson/jenkins.

set -e
set -u

fail=0
#TODO: Run these in parallel - we have 4 cores.
#TODO: Control the environment (through the config dir?).
#      We want to parse for all environments.
#      Is this being done, contrary to puppet report?
#TODO: Even with --ignoreimport, some may be pulling in others,
#      meaning we're checking multiple times.
all_files=`find . -name "*.pp" -o -name "*.erb"`
num_files=`echo $all_files | wc -w`
if [[ $num_files -eq "0" ]]; then
  echo "ERROR: no .pp or .erb files found"
  exit 1
fi
echo "Checking $num_files *.pp and *.erb files for syntax errors."
echo "Puppet version is: `puppet --version`"

for x in $all_files; do
  set +e
  case $x in
  *.pp )
    puppet parser validate --color=false $x ;;
  *.erb )
    cat $x | erb -x -T - | ruby -c > /dev/null ;;
  esac
  rc=$?
  set -e
  if [[ $rc -ne 0 ]] ; then
    fail=1
    echo "ERROR in $x (see above)"
  fi
done

if [[ $fail -ne 0 ]] ; then
  echo "FAIL: at least one file failed syntax check."
else
  echo "SUCCESS: all .pp and *.erb files pass syntax check."
fi
exit $fail

#!/bin/bash

#Script to test puppet files have valid syntax.

#Intended for use with hudson/jenkins.

set -e

set -u

fail=0

#TODO: Run these in parallel - we have 4 cores.

#TODO: Control the environment (through the config dir?).

# We want to parse for all environments.

# Is this being done, contrary to puppet report?

#TODO: Even with --ignoreimport, some may be pulling in others,

# meaning we're checking multiple times.

all_files=`find . -name "*.pp" -o -name "*.erb"`

num_files=`echo $all_files | wc -w`

if [[ $num_files -eq "0" ]]; then

echo "ERROR: no .pp or .erb files found"

exit 1

echo "Checking $num_files *.pp and *.erb files for syntax errors."

echo "Puppet version is: `puppet --version`"

for x in $all_files; do

set +e

case $x in

*.pp )

puppet parser validate --color=false $x ;;

*.erb )

cat $x | erb -x -T - | ruby -c > /dev/null ;;

esac

rc=$?

set -e

if [[ $rc -ne 0 ]] ; then

fail=1

echo "ERROR in $x (see above)"

done

if [[ $fail -ne 0 ]] ; then

echo "FAIL: at least one file failed syntax check."

else

echo "SUCCESS: all .pp and *.erb files pass syntax check."

exit $fail

Update: I found the original source on GitHub

Have you ever tried working with a huge monolith of SVN repo that has lived for ages and seen a bazillion commits in its time? Then you might have experienced unpleasant times waiting for some process to chew through all that nasty pile of code.

Here is how I handle these behemoths – just checkout the subpath I need leaving all the history behind:

repopath=$1

folder=$2

lastrev=$(svn info $repopath | grep "Last Changed Rev:" | sed -e 's/.*: $\d*$/\1/')

git svn clone -r $lastrev $repopath $folder

This code snippet will fetch the latest revision the subpath was edited and do a sparse shallow checkout using git as client.

E5K.de

Just another WordPress site

Month: April 2014

Quick Puppet Syntax Check

Sparse Shallow Checkout an SNV Repo using Git